fix(adk): avoid cancel context races in concurrent ChatModelAgent runs - #1185
Open
LPX-E5BD8 wants to merge 2 commits into
Open
fix(adk): avoid cancel context races in concurrent ChatModelAgent runs#1185LPX-E5BD8 wants to merge 2 commits into
LPX-E5BD8 wants to merge 2 commits into
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a data race when a long-lived ChatModelAgent is used concurrently on the tools/ReAct execution path by ensuring per-run cancellation state is written to a per-run config copy rather than mutating a shared reactConfig / modelWrapperConf.
Changes:
- Copy
reactConfig(andmodelWrapperConfwhen present) inside eachRunclosure before injectingcancelCtx, avoiding shared mutable state across concurrent runs. - Apply the same per-run config copy approach to both message-based and agentic ReAct run functions.
- Add a concurrent regression test that exercises concurrent
Runcalls on a shared agent with tools enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
adk/chatmodel.go |
Avoids concurrent mutation of shared ReAct config by shallow-copying configs per run before setting cancel state. |
adk/chatmodel_concurrent_test.go |
Adds a concurrency regression test covering shared-agent concurrent runs on the tools/ReAct path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LPX-E5BD8
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1177
concurrent Run on one ChatModelAgent races on reactConfig.cancelCtx.
copy the config per run before writing cancelCtx.